This revision was automatically updated to reflect the committed changes.
Closed by commit rL343019: [clangd] Extract mapper logic from clangd-indexer
into a library. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
sammccall added a comment.
On second thoughts, let's just leave the MR functionality in place for now so
this can be landed.
Then the out-of-tree stuff can migrate to the library, and we can rip out the
MR stuff soon.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52465
___
sammccall updated this revision to Diff 166970.
sammccall added a comment.
Leave functionality of clangd-indexer unchanged, to make this easier to land.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52465
Files:
clangd/CMakeLists.txt
clangd/index/IndexAction.cpp
clangd/i
sammccall updated this revision to Diff 166968.
sammccall marked an inline comment as done.
sammccall added a comment.
Rebase and address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52465
Files:
clangd/CMakeLists.txt
clangd/index/IndexAction.cpp
clangd/index/
sammccall marked 3 inline comments as done.
sammccall added a comment.
Thanks!
Will land in a day or two, we maintain some out-of-tree mapreduce patches to
this file that I need to turn into a real fork.
Comment at: clangd/index/IndexAction.h:24
+// - references are always c
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for factoring out this to a library.
Comment at: clangd/index/IndexAction.cpp:41
+ llvm::errs()
+ << "Found uncompilable errors in the translat
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov, mgorny.
Drop support for MR-via-YAML, it's slow and the merge still doesn't scale.
Repository:
rCTE Clang Tools Extra
https://revie
