[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343568: [clang] Implement Override Suggestions in Sema. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D52225?vs=167717&id=167902#toc Repository: rC Clang h

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet updated this revision to Diff 167717. kadircet added a comment. - Add a fixme on limitation. Repository: rC Clang https://reviews.llvm.org/D52225 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/overrides.cpp Index: test/CodeC

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet updated this revision to Diff 167708. kadircet marked 4 inline comments as done. kadircet added a comment. - Fix a bug and address comments. Repository: rC Clang https://reviews.llvm.org/D52225 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:1639 +llvm::raw_string_ostream OS(OverrideSignature); +CodeCompletionResult CCR(Method, 0); +PrintingPolicy Policy = ioeric wrote: > kadircet wrote: > > ioeric wrote

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Sema/SemaCodeComplete.cpp:1639 +llvm::raw_string_ostream OS(OverrideSignature); +CodeCompletionResult CCR(Method, 0); +PrintingPoli

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:1639 +llvm::raw_string_ostream OS(OverrideSignature); +CodeCompletionResult CCR(Method, 0); +PrintingPolicy Policy = ioeric wrote: > Could you add comments explainin

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet updated this revision to Diff 167700. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments. Repository: rC Clang https://reviews.llvm.org/D52225 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test/CodeCompletio

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

ioeric added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:1603 + const CodeCompletionContext &CCContext, + CodeCompletionBuilder &Builder, Sema &S) { + const auto *CR = llvm::dyn_cast(S.CurContext); --

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet added a comment. ping Repository: rC Clang https://reviews.llvm.org/D52225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet updated this revision to Diff 167071. kadircet added a comment. - Change order of fucntions for better diff. - Add tests. Repository: rC Clang https://reviews.llvm.org/D52225 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/ove

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

ioeric added a comment. Could you move the corresponding tests from clangd to sema? Comment at: lib/Sema/SemaCodeComplete.cpp:3063 +CodeCompletionString * +CodeCompletionResult::CreateCodeCompletionString(ASTContext &Ctx, + Prepro

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added a subscriber: cfe-commits. In clangd we had a new type of completion suggestions for cpp class/struct/unions that will show override signatures for virtual methods in base classes. This patch implements i