This revision was automatically updated to reflect the committed changes.
Closed by commit rL340262: [clangd] Allow using experimental Dex index
(authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50897?vs=161679&id=1
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D50897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
kbobyrev updated this revision to Diff 161679.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Aww, the previous diff was the wrong one and didn't contain docs.
The move of the code to the middle of Clangd driver was justified by the
assumption that it might be better to mov
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/MemIndex.h:50
+// FIXME(kbobyrev): Document this one.
+std::shared_ptr>
Please add documentation.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:96
+namespac
kbobyrev updated this revision to Diff 161487.
kbobyrev marked an inline comment as done.
https://reviews.llvm.org/D50897
Files:
clang-tools-extra/clangd/index/MemIndex.cpp
clang-tools-extra/clangd/index/MemIndex.h
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/i
ioeric added inline comments.
Herald added a subscriber: kadircet.
Comment at: clang-tools-extra/clangd/index/Index.h:360
+ template
+ static std::unique_ptr build(SymbolSlab Slab) {
+ struct Snapshot {
I'd try to avoid this pattern as it implicitly requires
kbobyrev updated this revision to Diff 161239.
kbobyrev added a comment.
Fix anonymous namespace beginning placement in Clangd driver.
https://reviews.llvm.org/D50897
Files:
clang-tools-extra/clangd/index/Index.h
clang-tools-extra/clangd/index/MemIndex.cpp
clang-tools-extra/clangd/index/M
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: arphaman, jkorous, MaskRay.
This patch adds hidden Clangd flag which replaces (currently) default
`MemIndex` with `DexIndex` for the static index
