BillyONeal closed this revision.
BillyONeal marked 2 inline comments as done.
BillyONeal added a comment.
Committed r339212
https://reviews.llvm.org/D50421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
BillyONeal updated this revision to Diff 159632.
BillyONeal added a comment.
Remove comma.
https://reviews.llvm.org/D50421
Files:
test/std/utilities/template.bitset/includes.pass.cpp
Index: test/std/utilities/template.bitset/includes.pass.cpp
BillyONeal added inline comments.
Comment at: test/std/utilities/template.bitset/includes.pass.cpp:11
+// test that includes , and
#include
template void test_typedef() {}
Quuxplusone wrote:
> grammar nit: comma
NP: Oxford Comma by Vampire Weekend
https:
Quuxplusone added inline comments.
Comment at: test/std/utilities/template.bitset/includes.pass.cpp:11
+// test that includes , and
#include
template void test_typedef() {}
grammar nit: comma
https://reviews.llvm.org/D50421
___
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This looks fine to me.
https://reviews.llvm.org/D50421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
BillyONeal created this revision.
BillyONeal added reviewers: mclow.lists, EricWF.
[template.bitset] says only that and are included by
, but libcxx tests are asserting that and are
also included.
Note that libcxx's nonstandard assertion of this is already handled by
test/libcxx/utilities/
