BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF.
[template.bitset] says only that <string> and <iosfwd> are included by <bitset>, but libcxx tests are asserting that <cstddef> and <stdexcept> are also included. Note that libcxx's nonstandard assertion of this is already handled by test/libcxx/utilities/template.bitset/includes.pass.cpp https://reviews.llvm.org/D50421 Files: test/std/utilities/template.bitset/includes.pass.cpp Index: test/std/utilities/template.bitset/includes.pass.cpp =================================================================== --- test/std/utilities/template.bitset/includes.pass.cpp +++ test/std/utilities/template.bitset/includes.pass.cpp @@ -1,32 +1,24 @@ + //===----------------------------------------------------------------------===// // // The LLVM Compiler Infrastructure // // This file is dual licensed under the MIT and the University of Illinois Open // Source Licenses. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// -// test that <bitset> includes <cstddef>, <string>, <stdexcept> and <iosfwd> +// test that <bitset> includes <string>, and <iosfwd> #include <bitset> template <class> void test_typedef() {} int main() { - { // test for <cstddef> - std::ptrdiff_t p; ((void)p); - std::size_t s; ((void)s); - std::nullptr_t np; ((void)np); - } { // test for <string> std::string s; ((void)s); } - { // test for <stdexcept> - std::logic_error le("blah"); ((void)le); - std::runtime_error re("blah"); ((void)re); - } { // test for <iosfwd> test_typedef<std::ios>(); test_typedef<std::wios>();
Index: test/std/utilities/template.bitset/includes.pass.cpp =================================================================== --- test/std/utilities/template.bitset/includes.pass.cpp +++ test/std/utilities/template.bitset/includes.pass.cpp @@ -1,32 +1,24 @@ + //===----------------------------------------------------------------------===// // // The LLVM Compiler Infrastructure // // This file is dual licensed under the MIT and the University of Illinois Open // Source Licenses. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// -// test that <bitset> includes <cstddef>, <string>, <stdexcept> and <iosfwd> +// test that <bitset> includes <string>, and <iosfwd> #include <bitset> template <class> void test_typedef() {} int main() { - { // test for <cstddef> - std::ptrdiff_t p; ((void)p); - std::size_t s; ((void)s); - std::nullptr_t np; ((void)np); - } { // test for <string> std::string s; ((void)s); } - { // test for <stdexcept> - std::logic_error le("blah"); ((void)le); - std::runtime_error re("blah"); ((void)re); - } { // test for <iosfwd> test_typedef<std::ios>(); test_typedef<std::wios>();
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits