This revision was automatically updated to reflect the committed changes.
Closed by commit rL339116: [clangd] Share getSymbolID implementation. (authored
by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50375
Files:
clang-tool
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:399
case CodeCompletionResult::RK_Pattern: {
-llvm::SmallString<128> USR;
-if (/*Ignore=*/clang::index::generateUSRForDecl(R.Declaration, USR))
- return None;
-return SymbolID(USR);
+return
hokein updated this revision to Diff 159466.
hokein marked 3 inline comments as done.
hokein added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50375
Files:
clangd/AST.cpp
clangd/AST.h
clangd/CodeComplete.cpp
clangd/XRefs.cpp
clangd/inde
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/AST.cpp:59
+ llvm::SmallString<128> USR;
+ if (index::generateUSRForDecl(D, USR)) {
+return None;
nit: no braces
=
hokein created this revision.
hokein added a reviewer: ioeric.
Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov.
And remove all duplicated implementation.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50375
Files:
clangd/AST.cpp
clangd/AST.h
clangd/Cod
