hokein added inline comments.
================
Comment at: clangd/CodeComplete.cpp:399
case CodeCompletionResult::RK_Pattern: {
- llvm::SmallString<128> USR;
- if (/*Ignore=*/clang::index::generateUSRForDecl(R.Declaration, USR))
- return None;
- return SymbolID(USR);
+ return clang::clangd::getSymbolID(R.Declaration);
}
----------------
ioeric wrote:
> No need for namespace qualifiers?
We need the qualifiers to disambiguate the function name, because this function
name is also `getSymbolID`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50375
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
