This revision was automatically updated to reflect the committed changes.
Closed by commit rL339693 (authored by kpn, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49865?vs=158351&id=160626#toc
Repository:
rL LLVM
https://reviews.
kpn updated this revision to Diff 158351.
kpn added a comment.
This includes the change to pass the annotation token when FENV_ACCESS is
turned off.
https://reviews.llvm.org/D49865
Files:
include/clang/AST/Expr.h
include/clang/Basic/LangOptions.h
include/clang/Basic/TokenKinds.def
incl
kpn updated this revision to Diff 158307.
kpn added a comment.
Replace accidentally lost comment.
https://reviews.llvm.org/D49865
Files:
include/clang/AST/Expr.h
include/clang/Basic/LangOptions.h
include/clang/Basic/TokenKinds.def
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
kpn updated this revision to Diff 158229.
kpn added a comment.
Thanks for the fast turnaround! I don't have commit access, can I get you to
commit it for me? And can I get you to put my email address
in the commit message?
I'll start looking at Sema like you said.
https://reviews.llvm.org/D4
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Parse/ParsePragma.cpp:619-623
+#if NOTYET // FIXME: Add this cli option when it makes sense.
+ case tok::OOS_DEFAULT:
+FPC = getLangOpts().getDefault
kpn marked 3 inline comments as done.
kpn added inline comments.
Comment at: include/clang/Basic/LangOptions.h:273-280
FPOptions() : fp_contract(LangOptions::FPC_Off) {}
// Used for serializing.
explicit FPOptions(unsigned I)
: fp_contract(static_cast(I)) {}
kpn updated this revision to Diff 158036.
kpn added a comment.
Updated based on review.
https://reviews.llvm.org/D49865
Files:
include/clang/AST/Expr.h
include/clang/Basic/LangOptions.h
include/clang/Basic/TokenKinds.def
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Par
rsmith added a comment.
Thanks, this is definitely a step in the right direction.
Comment at: include/clang/AST/Expr.h:3257-3261
+ // Get the FENV_ACCESS status of this operator. Only meaningful for
+ // operations on floating point types.
+ bool isFENVAccessOn() const {
+
kpn created this revision.
kpn added reviewers: rsmith, craig.topper, hfinkel.
Herald added a subscriber: cfe-commits.
We have in place support for parsing #pragma FENV_ACCESS, but that information
is then discarded with a warning to the user that we don't support it.
This patch gets us one step
