JonasToth added a comment.
Please dont work in this revision but create a new one (as this one is
already committed)!
Am 24.08.2018 um 17:34 schrieb Andi via Phabricator:
> Abpostelnicu updated this revision to Diff 162387.
>
> https://reviews.llvm.org/D49851
>
> Files:
>
> clang-tidy/tool/
Abpostelnicu updated this revision to Diff 162387.
https://reviews.llvm.org/D49851
Files:
clang-tidy/tool/run-clang-tidy.py
Index: clang-tidy/tool/run-clang-tidy.py
===
--- clang-tidy/tool/run-clang-tidy.py
+++ clang-tidy/tool/ru
Abpostelnicu added a comment.
In https://reviews.llvm.org/D49851#1203676, @JonasToth wrote:
> In https://reviews.llvm.org/D49851#1202764, @Abpostelnicu wrote:
>
> > Strangely I haven't had those kind of issues but since you propose those
> > modifications I would do one more modification, let's
JonasToth added a comment.
In https://reviews.llvm.org/D49851#1202764, @Abpostelnicu wrote:
> Strangely I haven't had those kind of issues but since you propose those
> modifications I would do one more modification, let's output everything to
> stdout and not stderr by doing:
>
> if err:
>
Abpostelnicu added a comment.
Strangely I haven't had those kind of issues but since you propose those
modifications I would do one more modification, let's output everything to
stdout and not stderr by doing:
if err:
sys.stdout.write(str(err) + '\n')
Repository:
rL LLVM
https://revi
R2RT reopened this revision.
R2RT added a comment.
This revision is now accepted and ready to land.
Hey, all, as for me it seems that this commit introduced a few problems with
Python3 (at least 3.7)
sys.stdout.write(' '.join(invocation) + '\n' + output + '\n')
TypeError: can only concatenat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339427: [clang-tidy] run-clang-tidy.py - add
synchronisation to the output (authored by Abpostelnicu, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D49851
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
JonasToth added a comment.
@alexfh or @aaron.ballman could you take a final look on this one?
https://reviews.llvm.org/D49851
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
No nothing. I think it is barely noticable in general. From prior long
runs i notices the scrambled messages, but it was only a small fraction.
So most of the time the threads dont seem to interfere, which makes the
lock kinda low-cost.
Am 07.08.2018 um 19:17 schrieb An
Abpostelnicu added a comment.
Did you notice any significant speed degradation?
https://reviews.llvm.org/D49851
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
I do run it over llvm/lib, there is no visible effect. from my experience maybe
1-5% of the lines are interleafed without the patch, too.
https://reviews.llvm.org/D49851
___
cfe-commits mailing list
cfe-commits@lists.llvm
JonasToth added a comment.
Lets say running it over whole LLVM for one check? I will apply this path
locally, because i have to analyze llvm right now anyway.
For me this looks good, but @alexfh or @aaron.ballman should accept it.
https://reviews.llvm.org/D49851
Abpostelnicu marked 2 inline comments as done.
Abpostelnicu added a comment.
Regarding the time penalty it depends very much on how many files you have. But
I would choose anytime to have this in the detriment of having "obfuscated"
output.
https://reviews.llvm.org/D49851
__
Abpostelnicu updated this revision to Diff 159511.
https://reviews.llvm.org/D49851
Files:
clang-tidy/tool/run-clang-tidy.py
Index: clang-tidy/tool/run-clang-tidy.py
===
--- clang-tidy/tool/run-clang-tidy.py
+++ clang-tidy/tool/ru
JonasToth added a comment.
I forgot: Did you measure how much of a time penalty this brings? Just out of
curiosity, correct script is more important then fast script :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49851
___
cfe-c
JonasToth added a comment.
I would like to have this patch in, because i currently have a 1MB output file,
and the missing synchronization really destroys cleaning with grep and sed :(
Comment at: clang-tidy/tool/run-clang-tidy.py:167
+output, err = proc.communicate()
+
Abpostelnicu created this revision.
Abpostelnicu added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
The goal of this patch is to add synchronisation of the output of the tool with
the actual files that are verified. Without it the output of clang-tidy will
get
18 matches
Mail list logo
