JonasToth added a comment.
I would like to have this patch in, because i currently have a 1MB output file,
and the missing synchronization really destroys cleaning with grep and sed :(
================
Comment at: clang-tidy/tool/run-clang-tidy.py:167
+ output, err = proc.communicate()
+ if proc.returncode:
failed_files.append(name)
----------------
Please do the comparison `!= 0` to be more clear about the expected success
return value.
================
Comment at: clang-tidy/tool/run-clang-tidy.py:171
+ sys.stdout.write(' '.join(invocation) + '\n' + output + '\n')
+ if len(err):
+ sys.stderr.write(err + '\n')
----------------
Please add a comparison you are looking for (`> 0` i guess)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49851
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
