ilya-biryukov added a comment.
In https://reviews.llvm.org/D49794#1182296, @yvvan wrote:
> Clang tidy is not only a standalone tool but also a plugin. It's almost never
> used this way (but we do that in Qt Creator to combine it with Clazy) and it
> also seems that some of the recent checks are
yvvan added a comment.
In https://reviews.llvm.org/D49794#1182272, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D49794#1182220, @yvvan wrote:
>
> > And we already saw, that -isystem is not the best choice for that.
>
>
> Are you referring to the file-locking on Windows?
> Any other reaso
ilya-biryukov added a comment.
In https://reviews.llvm.org/D49794#1182220, @yvvan wrote:
> And we already saw, that -isystem is not the best choice for that.
Are you referring to the file-locking on Windows?
Any other reasons why the -isystem trick might be non-ideal?
> And by the way - clang
yvvan added a comment.
Anyways, if c++ part does not seem relevant I'm fine if we only have libclang
part from https://reviews.llvm.org/D48116.
BTW I don't remember if you answered something to my suggestion of adding flag
-ithird-party as an alternative to -isystem which does not lock files an
yvvan added a comment.
And we already saw, that -isystem is not the best choice for that. And by the
way - clang-tidy has this filtering in consumer which does not exist in it's
plugin-mode so it spits all system diagnostics all the time...
https://reviews.llvm.org/D49794
__
ilya-biryukov added a comment.
In https://reviews.llvm.org/D49794#1182078, @yvvan wrote:
> I already mentioned in the review inherited by this one that this way covers
> also loaded plugins with different consumers. So let's assume that driver
> loads clang-tidy and some other plugins and runs
yvvan added a comment.
I already mentioned in the review inherited by this one that this way covers
also loaded plugins with different consumers. So let's assume that driver loads
clang-tidy and some other plugins and runs over each file in the project.
It makes sense not to include clang-tidy d
ilya-biryukov added inline comments.
Comment at: include/clang/Driver/Options.td:1745
HelpText<"remap file source paths in debug info">;
+def fsuppress_non_errors_from_included_files : Flag<["-"],
"fsuppress-non-errors-from-included-files">,
+ Group, Flags<[CC1Option]>;
--
yvvan updated this revision to Diff 158211.
yvvan added a comment.
Restore missing tests
https://reviews.llvm.org/D49794
Files:
include/clang-c/Index.h
include/clang/Basic/Diagnostic.h
include/clang/Basic/DiagnosticOptions.def
include/clang/Driver/Options.td
lib/Basic/DiagnosticIDs.cp
yvvan created this revision.
yvvan added reviewers: ilya-biryukov, bkramer, akyrtzi, malaperle.
Updated clone for https://reviews.llvm.org/D48116 by Nikolai, now also adds the
clang driver flag and the test for it.
If clang has plugins they are also affected by this filtering.
Depending on the i
10 matches
Mail list logo
