[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Herald added a subscriber: abrachet. Herald added a reviewer: libc++. Herald added projects: libc++abi, libunwind, All. Herald added a reviewer: libc++abi. Herald added a reviewer: li

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

ldionne added a comment. I think the right way to do this was to use `install(export)`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49587/new/ https://reviews.llvm.org/D49587 ___ cfe-commits mailing

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

ldionne added a comment. In D49587#1493585 , @ldionne wrote: > I think the right way to do this was to use `install(export)`? Oh, and you are doing this, but in `llvm/runtimes`. Why don't we handle this per project? I don't think we should assume that t

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

smeenai added inline comments. Comment at: libunwind/src/CMakeLists.txt:160 if (LIBUNWIND_INSTALL_LIBRARY) - install(TARGETS ${LIBUNWIND_INSTALL_TARGETS} + if(libcxxabi IN_LIST LLVM_RUNTIME_DISTRIBUTION_COMPONENTS) +set(export_to_llvmruntimes EXPORT LLVMRuntimes) -

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek updated this revision to Diff 198347. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49587/new/ https://reviews.llvm.org/D49587 Files: clang/cmake/c

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek added a comment. In D49587#1488328 , @smeenai wrote: > Seems like you got the wrong diff. It was the right diff but uploaded to a wrong change ;) In D49587#1484829 , @smeenai wrote: > Sorry, had missed th