[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman abandoned this revision. arphaman added a comment. Abandoned in favor of https://reviews.llvm.org/D49758 (will update it today). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49523 ___ cfe-commits mailing list cfe-commits@

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1174627, @ilya-biryukov wrote: > In https://reviews.llvm.org/D49523#1174086, @arphaman wrote: > > > We actually need both mechanisms. I posted the didChangeConfiguration > > extension to https://reviews.llvm.org/D49758. > > > Why do we

[PATCH] D49523: [clangd] Add support for per-file override compilation command

ilya-biryukov added a comment. In https://reviews.llvm.org/D49523#1174086, @arphaman wrote: > We actually need both mechanisms. I posted the didChangeConfiguration > extension to https://reviews.llvm.org/D49758. Why do we need both? Can we have only the one from https://reviews.llvm.org/D4975

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1171484, @ilya-biryukov wrote: > The extensions itself seems like a reasonable way to provide compile commands > for the individual files. In case didChangeConfiguration does not work for > you for some reason, happy to take a look at

[PATCH] D49523: [clangd] Add support for per-file override compilation command

ilya-biryukov added a comment. The extensions itself seems like a reasonable way to provide compile commands for the individual files. In case didChangeConfiguration does not work for you for some reason, happy to take a look at this change too. One drawback of using didChangeConfiguration for c

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1169621, @jkorous wrote: > Alex, I am just wondering if we shouldn't rather create another > implementation of GlobalCompilationDatabase interface (something like > InMemoryGlobalCompilationDatabase), add it to ClangdServer and use it

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1169728, @malaperle wrote: > In https://reviews.llvm.org/D49523#1169000, @arphaman wrote: > > > In https://reviews.llvm.org/D49523#1167553, @malaperle wrote: > > > > > Interesting! We also have a need for passing compilation commands in

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1169743, @jkorous wrote: > BTW it looks like we already had kind of support for compilation command > before (extra flags). > > commit 5ec1f7ca32eb85077a22ce81d41aa02a017d4852 > Author: Krasimir Georgiev > Date: Thu Jul 6 08:44:54

[PATCH] D49523: [clangd] Add support for per-file override compilation command

jkorous added a comment. BTW it looks like we already had kind of support for compilation command before (extra flags). commit 5ec1f7ca32eb85077a22ce81d41aa02a017d4852 Author: Krasimir Georgiev Date: Thu Jul 6 08:44:54 2017 + [clangd] Add support for per-file extra flags There is even

[PATCH] D49523: [clangd] Add support for per-file override compilation command

malaperle added a comment. In https://reviews.llvm.org/D49523#1169000, @arphaman wrote: > In https://reviews.llvm.org/D49523#1167553, @malaperle wrote: > > > Interesting! We also have a need for passing compilation commands in a > > context where there is no compile_commands.json, but we were th

[PATCH] D49523: [clangd] Add support for per-file override compilation command

jkorous added a comment. Alex, I am just wondering if we shouldn't rather create another implementation of GlobalCompilationDatabase interface (something like InMemoryGlobalCompilationDatabase), add it to ClangdServer and use it as the first place to be searched in ClangdServer::getCompileComma

[PATCH] D49523: [clangd] Add support for per-file override compilation command

jkorous added a comment. Hi Marc-Andre, what is a structure of data you are passing as parameter of didChangeConfiguration message? All we need is to pass per-file compilation command to clangd. Maybe we could send didChangeConfiguration message right after didOpen. Repository: rCTE Clang T

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1167553, @malaperle wrote: > Interesting! We also have a need for passing compilation commands in a > context where there is no compile_commands.json, but we were thinking of > putting this in a "didChangeConfiguration" message so tha

[PATCH] D49523: [clangd] Add support for per-file override compilation command

malaperle added a comment. Interesting! We also have a need for passing compilation commands in a context where there is no compile_commands.json, but we were thinking of putting this in a "didChangeConfiguration" message so that all the commands would be available even before files are opened.

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. Btw, the "extraFlags" extension is still usable with "compilationCommand". Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman created this revision. arphaman added reviewers: jkorous, sammccall, ilya-biryukov. arphaman added a project: clang-tools-extra. Herald added subscribers: dexonsmith, MaskRay, ioeric. This patch builds on top of the "extra flags" extension added in r307241. It adds the ability to specify