tra added a comment.
We normally do not need to deviate from the host options all that often. I
would argue that keeping options identical is a reasonable default for most
options.
For some options the driver may be able to derive a sensible value based on the
host options. E.g. some options ca
echristo added a comment.
In https://reviews.llvm.org/D49148#1184957, @tra wrote:
> I wonder, what's the right thing to do to silence the warnings. For instance,
> we compile everything with -Werror and the warnings result in build breaks.
>
> Easy way out is to pass `-Wno-unsupported-target-opt
tra added a comment.
I wonder, what's the right thing to do to silence the warnings. For instance,
we compile everything with -Werror and the warnings result in build breaks.
Easy way out is to pass `-Wno-unsupported-target-opt`. It works, but it does
not really solve anything. It also may mas
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338155: [DEBUGINFO] Disable unsupported debug info options
for NVPTX target. (authored by ABataev, committed by ).
Change
ABataev added a comment.
Eric accepted the patch offline.
Repository:
rC Clang
https://reviews.llvm.org/D49148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev marked an inline comment as done.
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:933-938
+ if (TC.supportsDebugInfoOption(A)) {
+Action();
+return true;
+ }
+ reportUnsupportedDebugInfoOption(A, Args, D, TC.getTriple());
+ return fa
ABataev updated this revision to Diff 157563.
ABataev added a comment.
Address ERic's comments.
Repository:
rC Clang
https://reviews.llvm.org/D49148
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/ToolChain.h
lib/Driver
echristo added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:933-938
+ if (TC.supportsDebugInfoOption(A)) {
+Action();
+return true;
+ }
+ reportUnsupportedDebugInfoOption(A, Args, D, TC.getTriple());
+ return false;
I'd probably simpli
ABataev updated this revision to Diff 156575.
ABataev added a comment.
Added checks for all possible debug options.
Repository:
rC Clang
https://reviews.llvm.org/D49148
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/Tool
echristo added a comment.
Getting close, one inline comment.
Comment at: lib/Driver/ToolChains/Cuda.h:161
bool SupportsProfiling() const override { return false; }
+ bool supportsDebugInfoOption(const llvm::opt::Arg *) const override {
+return false;
I'
ABataev updated this revision to Diff 156139.
ABataev added a comment.
Renamed function supportsNonDefaultDebugOptions() ->
supportsDebugInfoOption(const Arg*). Instead of the enum it accepts and should
check one of the debug info options.
Repository:
rC Clang
https://reviews.llvm.org/D4914
echristo added a comment.
In https://reviews.llvm.org/D49148#1166859, @echristo wrote:
> In https://reviews.llvm.org/D49148#1166429, @ABataev wrote:
>
> > In https://reviews.llvm.org/D49148#1165826, @echristo wrote:
> >
> > > I think you should break it out on an option by option basis. Just
> >
echristo added a comment.
In https://reviews.llvm.org/D49148#1166429, @ABataev wrote:
> In https://reviews.llvm.org/D49148#1165826, @echristo wrote:
>
> > I think you should break it out on an option by option basis. Just warning
> > on "non-standard" options won't make as much sense to end user
ABataev added a comment.
In https://reviews.llvm.org/D49148#1165826, @echristo wrote:
> I think you should break it out on an option by option basis. Just warning on
> "non-standard" options won't make as much sense to end users. Perhaps a "this
> option is unsupported on the target you're comp
echristo added a comment.
I think you should break it out on an option by option basis. Just warning on
"non-standard" options doesn't really make sense.
Repository:
rC Clang
https://reviews.llvm.org/D49148
___
cfe-commits mailing list
cfe-commi
ABataev created this revision.
ABataev added a reviewer: echristo.
Herald added subscribers: JDevlieghere, aprantl.
Some targets support only default set of the debug options and do not
support additional debug options, like NVPTX target. Patch introduced
virtual function supportsNonDefaultDebugOp
16 matches
Mail list logo
