echristo added a comment.

Getting close, one inline comment.



================
Comment at: lib/Driver/ToolChains/Cuda.h:161
   bool SupportsProfiling() const override { return false; }
+  bool supportsDebugInfoOption(const llvm::opt::Arg *) const override {
+    return false;
----------------
I'd like to see this for all of the possible options (returning false by 
default is fine), with the ones supported spelled out (-gdwarf/-gdwarf-2/etc). 
This means you'll probably have to check this at all option processing sites 
for debug info. Alternately you could check g_group flags as a whole first and 
then process individually.


Repository:
  rC Clang

https://reviews.llvm.org/D49148



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to