[PATCH] D48493: [HIP] Support flush denorms bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rC335765: [HIP] Support flush denormals bitcode (authored by aaronenyeshi, committed by ). Changed prior to commit: https://reviews.llvm.org/D48493?vs=153146&id=153147#toc Repository: rC Clang https:/

[PATCH] D48493: [HIP] Support flush denorms bitcode

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D48493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D48493: [HIP] Support flush denorms bitcode

ashi1 updated this revision to Diff 153146. ashi1 added a comment. Merged checks for flush denorm on and off into single test hip-device-libs.hip https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc test/Driver/Inputs/hip_dev_l

[PATCH] D48493: [HIP] Support flush denorms bitcode

yaxunl added a comment. better merge these two tests and rename it as hip-device-libs.hip. We can also add other device lib tests to it later. https://reviews.llvm.org/D48493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D48493: [HIP] Support flush denorms bitcode

ashi1 updated this revision to Diff 153140. https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc test/Driver/Inputs/hip_dev_lib/ockl.amdgcn.bc test/Driver/Inputs/hip_dev_lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc test/Drive

[PATCH] D48493: [HIP] Support flush denorms bitcode

ashi1 updated this revision to Diff 153136. ashi1 added a comment. I've updated. Moved the bitcode files into hip_dev_lib and added test for both on and off flush denorms to zero option. https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_dev_lib/iri

[PATCH] D48493: [HIP] Support flush denorms bitcode

yaxunl added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:85 "ockl.amdgcn.bc", "irif.amdgcn.bc", "ocml.amdgcn.bc", "oclc_finite_only_off.amdgcn.bc", + FlushDenormalControlBC, we need to fix t

[PATCH] D48493: [HIP] Support flush denorms bitcode

yaxunl added inline comments. Comment at: test/Driver/hip-toolchain-flush-denorms.hip:6 +// RUN: %clang -### -target x86_64-linux-gnu \ +// RUN: -x hip --cuda-gpu-arch=gfx803 --cuda-gpu-arch=gfx900 \ +// RUN: --hip-device-lib-path=%S/Inputs/hip_multiple_inputs/dev_lib \ -

[PATCH] D48493: [HIP] Support flush denorms bitcode

ashi1 updated this revision to Diff 153131. ashi1 added a comment. Fix diff file https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_multiple_inputs/dev_lib/irif.amdgcn.bc test/Driver/Inputs/hip_multiple_inputs/dev_lib/ockl.amdgcn.bc test/Driver/

[PATCH] D48493: [HIP] Support flush denorms bitcode

ashi1 updated this revision to Diff 153127. ashi1 added a comment. Added diff with full context. https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_multiple_inputs/dev_lib/irif.amdgcn.bc test/Driver/Inputs/hip_multiple_inputs/dev_lib/ockl.amdgcn.bc

[PATCH] D48493: [HIP] Support flush denorms bitcode

ashi1 updated this revision to Diff 153124. ashi1 added a comment. I've changed the string to a more meaningful name, and also added a lit test to check that oclc_daz_opt_on.amdgcn.bc is used. https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_multi

[PATCH] D48493: [HIP] Support flush denorms bitcode

yaxunl added a comment. I think we should have a lit test for linked bitcode files. Comment at: lib/Driver/ToolChains/HIP.cpp:78 +std::string OCLC_daz_opt; +if (Args.hasArg(options::OPT_fcuda_flush_denormals_to_zero)) + OCLC_daz_opt = "oclc_daz_opt_on.amdgcn.bc"; -

[PATCH] D48493: [HIP] Support flush denorms bitcode

scchan added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D48493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48493: [HIP] Support flush denorms bitcode

b-sumner added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D48493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48493: [HIP] Support flush denorms bitcode

ashi1 created this revision. ashi1 added a reviewer: yaxunl. ashi1 added projects: clang, AMDGPU. Herald added a subscriber: cfe-commits. We need to use oclc_daz_opt_on.amdgcn.bc bitcode when option fcuda-flush-denormal-to-zero is enabled for HIP. Repository: rC Clang https://reviews.llvm.or