This revision was automatically updated to reflect the committed changes.
Closed by commit rL335422: [Coroutines] Less IR for noexcept await_resume
(authored by modocache, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D47673
Files:
cfe/trunk/lib/CodeGen/CGCoroutine.cpp
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335422: [Coroutines] Less IR for noexcept await_resume
(authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47673?vs=152599&id=152602#toc
Repository:
rC Clang
h
modocache updated this revision to Diff 152599.
modocache added a comment.
Great, thanks @GorNishanov! I moved the 'can throw' logic into a function
called 'memberCallExpressionCanThrow', to convey that some dyn_cast'ing is
going on.
Repository:
rC Clang
https://reviews.llvm.org/D47673
Fil
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM with some suggestions.
Comment at: lib/CodeGen/CGCoroutine.cpp:224
+ bool ResumeCanThrow = true;
+ if (const auto *MCE = dyn_cast(S.getResumeExpr()))
+if
modocache created this revision.
modocache added reviewers: GorNishanov, EricWF.
Herald added a subscriber: cfe-commits.
In his review of https://reviews.llvm.org/D45860, @GorNishanov suggested
avoiding generating additional exception-handling IR in the case that
the resume function was marked as
