GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land.
LGTM with some suggestions. ================ Comment at: lib/CodeGen/CGCoroutine.cpp:224 + bool ResumeCanThrow = true; + if (const auto *MCE = dyn_cast<CXXMemberCallExpr>(S.getResumeExpr())) + if (const auto *Proto = ---------------- This long sequence of if statements seems to be asking to be put into its own predicate function: expressionCanThrow or something like that. Repository: rC Clang https://reviews.llvm.org/D47673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits