labath added a comment.
In https://reviews.llvm.org/D47532#1144966, @martong wrote:
> The broken lldb tests are fixed with a minor change. We no longer load the
> Decls from the
> external source during the call of `DeclContext::containsDecl`. A new
> function
> `DeclContext::containsDeclAnd
martong added a comment.
The broken lldb tests are fixed with a minor change. We no longer load the
Decls from the
external source during the call of `DeclContext::containsDecl`. A new function
`DeclContext::containsDeclAndLoad` is added which does a load and calls
`containsDecl`.
Re-apply comm
martong added a comment.
This is not trivial to fix. Reverting until we can reproduce and fix it.
Reverted with commit: r335491
Repository:
rC Clang
https://reviews.llvm.org/D47532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
martong added a comment.
@labath
Sure, looking into it.
Repository:
rC Clang
https://reviews.llvm.org/D47532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
labath added subscribers: aprantl, labath.
labath added a comment.
This has broken the LLDB bot
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/25132.
Could you take a look?
Repository:
rC Clang
https://reviews.llvm.org/D47532
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335480: [ASTImporter] Import the whole redecl chain of
functions (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47532?vs=152691&id=152693#toc
Repository:
rC
martong added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:2021
+
+TEST_P(ImportFriendFunctions,
+ DISABLED_ImportFriendFunctionRedeclChainDefWithClass_ImportTheProto) {
a_sidorin wrote:
> Could you add comments why these tests are disable
martong updated this revision to Diff 152691.
martong marked 3 inline comments as done.
martong added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D47532
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
lib/AST/DeclBase.cpp
test/AST
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Hi Gabor,
The patch LG, thank you for addressing my questions. Just some stylish nits.
Comment at: unittests/AST/ASTImporterTest.cpp:2021
+
+TEST_P(ImportFriendFunctio
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:79
+for (auto R : D->getFirstDecl()->redecls()) {
+ if (R != D->getFirstDecl())
+Redecls.push_back(R);
a.sidorin wrote:
> Does this code mean that we can get R == getFirstDecl() i
martong updated this revision to Diff 152262.
martong marked 15 inline comments as done.
martong added a comment.
- Addressing Alexei's comments.
Repository:
rC Clang
https://reviews.llvm.org/D47532
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
lib/AST/DeclBase.cpp
t
martong added a comment.
> Are you OK with incremental review?
Hi Aleksei, thanks for reviewing this! Of course I am OK with an incremental
review. Just a minor thing, I'll be back in the office only at the 18th, so I
can address all of the comments only then.
Repository:
rC Clang
https://
a.sidorin added a comment.
Hello Gabor,
This patch is really cool. Unfortunately, right now I don't have enough time
for reviewing large patches in a single review. Are you OK with incremental
review?
Comment at: lib/AST/ASTImporter.cpp:75
+ template
+ llvm::SmallVector
+
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:88
+ llvm::SmallVector getCanonicalForwardRedeclChain(Decl* D) {
+// Currently only FunctionDecl is supported
+auto FD = cast(D);
balazske wrote:
> Assert for FunctionDecl?
`cast` itself
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:88
+ llvm::SmallVector getCanonicalForwardRedeclChain(Decl* D) {
+// Currently only FunctionDecl is supported
+auto FD = cast(D);
Assert for FunctionDecl?
Comment at:
martong added a comment.
I just wanted to give a detailed justification about why we should import the
whole redecl chain. Consider the following code:
void f(); // prototype
void f() { f(); }
Currently, when we import the prototype we end up having two independent
functions with definition
martong updated this revision to Diff 149107.
martong added a comment.
- Add a missing "else"
Repository:
rC Clang
https://reviews.llvm.org/D47532
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
lib/AST/DeclBase.cpp
test/ASTMerge/class/test.cpp
unittests/AST/ASTImpor
martong created this revision.
martong added reviewers: a.sidorin, r.stahl, xazax.hun, balazske.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
With this patch when any `FunctionDecl` of a redeclaration chain is imported
then we bring in the whole declaration chain. This involves functi
18 matches
Mail list logo
