This revision was automatically updated to reflect the committed changes.
Closed by commit rL333110: [X86] Move all Intel defined intrinsic includes into
immintrin.h (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
DavidKreitzer accepted this revision.
DavidKreitzer added a comment.
This revision is now accepted and ready to land.
Thanks, Craig. LGTM.
https://reviews.llvm.org/D47182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
craig.topper updated this revision to Diff 148252.
craig.topper added a comment.
Add back popcntintrin.h
https://reviews.llvm.org/D47182
Files:
lib/Headers/cldemoteintrin.h
lib/Headers/clzerointrin.h
lib/Headers/immintrin.h
lib/Headers/movdirintrin.h
lib/Headers/pconfigintrin.h
lib/
DavidKreitzer added a comment.
Hi Craig, just one comment on the details. Everything else looks good.
Comment at: lib/Headers/x86intrin.h:47
-
-#if !defined(_MSC_VER) || __has_feature(modules) || defined(__POPCNT__)
-#include
I see that you are removing this p
craig.topper updated this revision to Diff 148115.
craig.topper added a comment.
Leave the message still saying x86intrin.h. Change the error checks to look for
either x86intrin.h or immintrin.h to have been included. Really only the
immintrin.h check is necessary since that's the header that do
DavidKreitzer added a comment.
I agree with the changes in x86intrin.h and immintrin.h. For the others, I
question whether we ought to recommend inclusion of x86intrin.h or immintrin.h.
The distinction as I understand it is that immintrin.h is used for
Intel-specific intrinsics while x86intrin
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D47182#1107900, @craig.topper wrote:
> Eventually this was determined to not be very scalable to remember which
> header file contained what intrinsics and you have to ch
craig.topper added a comment.
First there was mmintrin.h which covered MMX instructions. Then xmmintrin.h
came along to support SSE1 and implicitly included mmintrin.h. The emmintrin.h
to support SSE2 and implicitly included xmmintrin.h. This repeated for each new
version of SSE. With each head
GBuella added a comment.
What does "imm" mean anyways?
Repository:
rC Clang
https://reviews.llvm.org/D47182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper created this revision.
craig.topper added reviewers: DavidKreitzer, echristo, RKSimon, rnk.
This matches the Intel documentation which shows them available by importing
immintrin.h. x86intrin.h also includes immintrin.h so anyone including
x86intrin.h will still get them.
This is d
10 matches
Mail list logo
