DavidKreitzer added a comment. Hi Craig, just one comment on the details. Everything else looks good.
================ Comment at: lib/Headers/x86intrin.h:47 - -#if !defined(_MSC_VER) || __has_feature(modules) || defined(__POPCNT__) -#include <popcntintrin.h> ---------------- I see that you are removing this popcntintrin.h inclusion without adding it to immintrin.h. Is that because you are relying on the inclusion from smmintrin.h? If so, won't that cause a problem on Windows with -mpopcnt for targets that don't include smmintrin.h? https://reviews.llvm.org/D47182 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
