[PATCH] D46234: Mark if a null statement is the result of constexpr folding

rsmith added a comment. In D46234#1762104 , @xazax.hun wrote: > Just a note for anyone willing to pick this up, PR32203 is also related. Further note: the right approach here would likely be to add a `DiscardedStmt` class deriving from `Stmt` that repre

[PATCH] D46234: Mark if a null statement is the result of constexpr folding

xazax.hun added a comment. Herald added subscribers: Charusso, gamesh411, Szelethus. Herald added a project: clang. Just a note for anyone willing to pick this up, PR32203 is also related. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46234/new/ https://reviews.l

[PATCH] D46234: Mark if a null statement is the result of constexpr folding

rsmith added a comment. In https://reviews.llvm.org/D46234#1082332, @xazax.hun wrote: > In https://reviews.llvm.org/D46234#1082307, @rsmith wrote: > > > Perhaps we should just use a null pointer for the not-instantiated arm of > > an `if constexpr` instead, rather than tracking a flag on an empt

[PATCH] D46234: Mark if a null statement is the result of constexpr folding

xazax.hun added a comment. In https://reviews.llvm.org/D46234#1082307, @rsmith wrote: > Can you say something about why you want to track this? The original motivation was to fix this false positive in clang tidy: https://reviews.llvm.org/D46027 > Perhaps we should just use a null pointer for

[PATCH] D46234: Mark if a null statement is the result of constexpr folding

rsmith added a comment. Can you say something about why you want to track this? Perhaps we should just use a null pointer for the not-instantiated arm of an `if constexpr` instead, rather than tracking a flag on an empty statement that is meaningless for real empty statements. Repository: r

[PATCH] D46234: Mark if a null statement is the result of constexpr folding

xazax.hun created this revision. xazax.hun added a reviewer: aaron.ballman. Herald added subscribers: dkrupp, rnkovacs. I did not add tests yet because first I wanted to be sure whether this approach is OK. Repository: rC Clang https://reviews.llvm.org/D46234 Files: include/clang/AST/Stmt