rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:4040-4041
// explicit nested-name-specifier).
- void MarkAnyDeclReferenced(SourceLocation Loc, Decl *D, bool MightBeOdrUse);
+ void MarkAnyDeclReferenced(SourceLocation Loc, Decl *D, bool MightBeOdrUse,
+
probinson accepted this revision.
probinson added a comment.
Although I am far from expert in how Clang manages declarations, AFAICT this
does what @rsmith requested, so LGTM.
https://reviews.llvm.org/D46190
___
cfe-commits mailing list
cfe-commits
CarlosAlbertoEnciso added a comment.
@rsmith & @probinson,
Is there anything I can add to this patch in order to submit it?
This patch is blocking the review https://reviews.llvm.org/D44826 which is
already approved.
Thanks very much.
Comment at: lib/Sema/SemaDeclCXX.cpp:155
CarlosAlbertoEnciso updated this revision to Diff 156460.
CarlosAlbertoEnciso marked an inline comment as done.
CarlosAlbertoEnciso added a comment.
A minor modification to allow the comments for `MarkNamespaceAliasReferenced`
to be picked up by doxygen.
https://reviews.llvm.org/D46190
Files:
CarlosAlbertoEnciso updated this revision to Diff 156456.
CarlosAlbertoEnciso added a comment.
Used `clang-format-diff` as indicated by @probinson:
- The lib and include files follow the clang format.
- The tests mostly follow the clang format. I removed some extra formatting
which was introduce
probinson added a comment.
@rsmith any further thoughts? We would really like to get this in before the
LLVM 7.0 branch, currently scheduled for 1 August.
In https://reviews.llvm.org/D46190#1168027, @CarlosAlbertoEnciso wrote:
> @probinson: I tried `clang-format-diff` and the main format issue
CarlosAlbertoEnciso added a comment.
@probinson: I tried `clang-format-diff` and the main format issues are with the
test cases.
Do you want the test cases to follow the clang format?
https://reviews.llvm.org/D46190
___
cfe-commits mailing list
cf
CarlosAlbertoEnciso added a comment.
In https://reviews.llvm.org/D46190#1166775, @probinson wrote:
> A bunch of style comments. Maybe try clang-format-diff.
@probinson:
Thanks very much for your review.
https://reviews.llvm.org/D46190
___
cfe-c
CarlosAlbertoEnciso added inline comments.
Comment at: include/clang/Sema/SemaInternal.h:91
Var->markUsed(SemaRef.Context);
+ SemaRef.MarkUsingReferenced(Var, Loc, /*CXXScopeSpec*=*/nullptr, RefExpr);
}
probinson wrote:
> The comments on a nullptr parameter
CarlosAlbertoEnciso updated this revision to Diff 156234.
CarlosAlbertoEnciso marked 11 inline comments as done.
CarlosAlbertoEnciso added a comment.
Address review comments from @probinson
https://reviews.llvm.org/D46190
Files:
include/clang/Sema/Lookup.h
include/clang/Sema/Sema.h
includ
probinson added a comment.
A bunch of style comments. Maybe try clang-format-diff.
Comment at: include/clang/Sema/SemaInternal.h:91
Var->markUsed(SemaRef.Context);
+ SemaRef.MarkUsingReferenced(Var, Loc, /*CXXScopeSpec*=*/nullptr, RefExpr);
}
The comments
CarlosAlbertoEnciso added a comment.
@rsmith and @probinson:
Is there anything I can add to this patch?
The review
https://reviews.llvm.org/D44826
is already approved and it is blocked by this patch being reviewed.
Thanks very much
https://reviews.llvm.org/D46190
CarlosAlbertoEnciso added a comment.
@rsmith Is there anything I can add to this patch?
The review
https://reviews.llvm.org/D44826
is already approved and it is dependent on this patch being reviewed.
Thanks very much
https://reviews.llvm.org/D46190
___
CarlosAlbertoEnciso added inline comments.
Comment at: lib/Sema/Sema.cpp:1884-1885
+ ND = NA->getAliasedNamespace();
+ if (auto *NNS = NA->getQualifier())
+MarkNamespaceAliasReferenced(NNS->getAsNamespaceAlias());
+}
rsmith wrote:
> The loop
CarlosAlbertoEnciso updated this revision to Diff 154091.
CarlosAlbertoEnciso added a comment.
Update the patch to address the comments from the reviewers.
https://reviews.llvm.org/D46190
Files:
include/clang/Sema/Lookup.h
include/clang/Sema/Sema.h
include/clang/Sema/SemaInternal.h
lib/
15 matches
Mail list logo
