probinson added a comment. @rsmith any further thoughts? We would really like to get this in before the LLVM 7.0 branch, currently scheduled for 1 August.
In https://reviews.llvm.org/D46190#1168027, @CarlosAlbertoEnciso wrote: > @probinson: I tried `clang-format-diff` and the main format issues are with > the test cases. > > Do you want the test cases to follow the clang format? The lib and include files absolutely need to follow clang format. Tests should also, if doing so doesn't disturb their readability. If clang-format-diff is doing things like rearranging comments in the test files, it depends on whether it improves or reduces clarity. Up to you. ================ Comment at: lib/Sema/SemaDeclCXX.cpp:15515 + +// Mark the alias declaration and any associated chain as referenced. +void Sema::MarkNamespaceAliasReferenced(NamedDecl *ND) { ---------------- This should use `///` to be picked up by doxygen. https://reviews.llvm.org/D46190 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
