xbolva00 added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Select
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Select
xbolva00 added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Select
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Select
xbolva00 added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Select
GBuella added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
+char c = Str[i];
+if (isalpha(c) || isnumber(c))
+ StringName += c;
GBuella wrote:
> theraven wrote:
> > Ka-Ka wrote:
> > > The isnumber() function was added to cc
GBuella added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
+char c = Str[i];
+if (isalpha(c) || isnumber(c))
+ StringName += c;
theraven wrote:
> Ka-Ka wrote:
> > The isnumber() function was added to cctype.h by Apple. I do
On Tue, May 22, 2018 at 10:31 AM, David Chisnall via Phabricator via
cfe-commits wrote:
> theraven added inline comments.
>
>
>
> Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
> +char c = Str[i];
> +if (isalpha(c) || isnumber(c))
> + StringName += c;
> --
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
+char c = Str[i];
+if (isalpha(c) || isnumber(c))
+ StringName += c;
Ka-Ka wrote:
> The isnumber() function was added to cctype.h by Apple. I don't think it can
>
Ka-Ka added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
+char c = Str[i];
+if (isalpha(c) || isnumber(c))
+ StringName += c;
The isnumber() function was added to cctype.h by Apple. I don't think it can be
used in llvm.
A
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, my comments seem to all be addressed.
Repository:
rC Clang
https://reviews.llvm.org/D46052
___
cfe-commits mailing list
cfe-commit
theraven marked 3 inline comments as done.
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:439
+ ArrayRef IvarOffsets,
+ ArrayRef IvarAlign,
+ ArrayRef IvarOwnership);
--
rjmccall added a comment.
Thanks, the comments help a lot.
Comment at: lib/CodeGen/CGObjCGNU.cpp:439
+ ArrayRef IvarOffsets,
+ ArrayRef IvarAlign,
+ ArrayRef IvarOwnership);
the
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:439
+ ArrayRef IvarOffsets,
+ ArrayRef IvarAlign,
+ ArrayRef IvarOwnership);
DHowett-MSFT wrote:
> While we'r
DHowett-MSFT added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:439
+ ArrayRef IvarOffsets,
+ ArrayRef IvarAlign,
+ ArrayRef IvarOwnership);
While we're here, is there v
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:977
+if ((CGM.getTarget().getPointerWidth(0) == 64) &&
+(SL->getLength() < 9) && !isNonASCII) {
+ // Tiny strings are (roughly):
rjmccall wrote:
> Please hoist `SL->getLength()
rjmccall added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:961
+ GV->setSection(Section);
+return GV;
+ }
I'd encourage you to use ConstantBuilder whenever you would want to use this.
Comment at: lib/CodeGen/CGObjCGNU.cpp:9
theraven added a comment.
In https://reviews.llvm.org/D46052#1078597, @rjmccall wrote:
> Are you asking for a code review or a design review of the ABI?
I don't think a design review is appropriate here, I am asking for a code
review.
> The second would be much easier to do from a design docu
rjmccall added a comment.
Are you asking for a code review or a design review of the ABI? The second
would be much easier to do from a design document.
Comment at: lib/CodeGen/CGObjCGNU.cpp:502
+for (const auto *I : Methods)
+ if (I->getImplementationControl() == Obj
19 matches
Mail list logo
