compnerd closed this revision.
compnerd added a comment.
SVN r331296
Repository:
rC Clang
https://reviews.llvm.org/D45814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chrib added a comment.
In https://reviews.llvm.org/D45814#1081203, @compnerd wrote:
> Do you have commit access or do you need someone to commit this on your
> behalf?
can you commit it for me please ? thanks.
Repository:
rC Clang
https://reviews.llvm.org/D45814
___
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Do you have commit access or do you need someone to commit this on your behalf?
Repository:
rC Clang
https://reviews.llvm.org/D45814
___
c
chrib added a comment.
Hi Saleem,
Thanks for your review. I have amended the patch to avoid checking the name on
the common path.
About your second comment, I'm not sure we have to fix -print-file-name= for an
equivalent problem since in case of empty parameter, we do a concatenation with
the
chrib updated this revision to Diff 144322.
chrib added a comment.
Move the non-null name check out of GetProgramPath and add a test case.
Assume that we trust the callers to check for non null ProgramName.
Repository:
rC Clang
https://reviews.llvm.org/D45814
Files:
lib/Driver/Driver.cpp
compnerd added a comment.
I'm torn on this. The other `-print` options will perform the validation
implicitly at the higher level before calling the inner functions. It is
certainly reasonable to support that, but, for the common path, this check
seems unnecessary (and this function is used e
chrib created this revision.
Herald added a subscriber: cfe-commits.
Fix an assertion when -print-prog-name=
Repository:
rC Clang
https://reviews.llvm.org/D45814
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
