jkorous closed this revision.
jkorous added a comment.
I forgot to mention review in commit message.
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@330608
91177308-0d34-0410-b5e6-96231b3b80d8
https://reviews.llvm.org/D45763
jkorous added a comment.
By "Comments should be allowed at the end of test files." I meant that we
shouldn't log it as an exceptional state. Should've worded that better.
I included a wrong test in the patch. I had realized the same thing as you and
had written another test but messed up.
htt
jkorous updated this revision to Diff 143079.
jkorous added a comment.
Include the correct test.
https://reviews.llvm.org/D45763
Files:
JSONRPCDispatcher.cpp
clangd/delimited-input-comment-at-the-end.test
Index: clangd/delimited-input-comment-at-the-end.test
==
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I can't see the bug/change related to "Comments should be allowed at the end of
test files." can you elaborate?
Comment at: clangd/delimited-input-comment-at-the-end.t
jkorous added a reviewer: sammccall.
jkorous added a comment.
Hi Sam, could you please take a look at this minor fix?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple,
ilya-biryukov.
Request in delimited input ended by EOF shouldn't be an error state.
Comments should be allowed at the end of test files.
Input mirrorin
