sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I can't see the bug/change related to "Comments should be allowed at the end of
test files." can you elaborate?
================
Comment at: clangd/delimited-input-comment-at-the-end.test:7
+{"jsonrpc":"2.0","id":3,"method":"exit"}
+# CHECK-NOT: Input message terminated by EOF
----------------
I'd actually lean towards dropping this test.
It's asserting that a magic string isn't present, and this patch removes the
only occurrence of the magic string from the code. I like the drive to test
every change, but it's hard to see this one ever failing :-)
(if you need a test with a trailing comment, maybe just throw one on the test
from the other patch and call it `delimited.test`)?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45763
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
