[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-18 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: lib/Headers/waitpkgintrin.h:41 +static __inline__ __UINT8_TYPE__ __DEFAULT_FN_ATTRS +_umwait (__UINT32_TYPE__ __CONTROL, __UINT64_TYPE__ __COUNTER) +{ I think we should use "unsigned int" and "unsigned long long" ex

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-18 Thread Gabor Buella via Phabricator via cfe-commits
GBuella updated this revision to Diff 142913. https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt lib/Headers/cpuid.h lib/Headers/waitpkgintrin.h lib

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-18 Thread Gabor Buella via Phabricator via cfe-commits
GBuella updated this revision to Diff 142910. GBuella added a comment. Modified the intrinsic. https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt lib/

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-06 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added inline comments. Comment at: lib/Headers/waitpkgintrin.h:41 +static __inline__ void __DEFAULT_FN_ATTRS +_umwait (__SIZE_TYPE__ __CONTROL, __UINT64_TYPE__ __COUNTER) +{ craig.topper wrote: > Why does the intrinsic take size_t but then its truncated

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-06 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. LGTM Comment at: lib/Headers/waitpkgintrin.h:41 +static __inline__ void __DEFAULT_FN_ATTRS +_umwait (__SIZE_TYPE__ __CONTROL, __UINT64_TYPE__ __COUNTER) +{ Why does the intrinsic take size_t b

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-06 Thread Gabor Buella via Phabricator via cfe-commits
GBuella updated this revision to Diff 141319. GBuella added a comment. Using the modified LLVM intrinsics from https://reviews.llvm.org/D45253. https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-04 Thread Gabor Buella via Phabricator via cfe-commits
GBuella created this revision. GBuella added reviewers: craig.topper, zvi. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/