This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rC333484: Add HIP toolchain (authored by yaxunl, committed by
).
Changed prior to commit:
https://reviews.llvm.org/D45212?vs=148277&id=149013#toc
Repository:
rC
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:44
+ }
+ if (!FoundLibDevice)
+C.getDriver().Diag(diag::err_drv_no_such_file) << BCName;
tra wrote:
> You don't need FoundLibDevice any more as
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
One small nit. LGTM otherwise.
Comment at: lib/Driver/ToolChains/HIP.cpp:44
+ }
+ if (!FoundLibDevice)
+C.getDriver().Diag(diag::err_drv_no_such_file) << BCName;
yaxunl updated this revision to Diff 148277.
yaxunl marked 6 inline comments as done.
yaxunl added a comment.
Revised by Artem's comments.
https://reviews.llvm.org/D45212
Files:
include/clang/Driver/Options.td
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/HIP.cpp
yaxunl marked 6 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:29-47
+static bool addBCLib(Compilation &C, const ArgList &Args,
+ ArgStringList &CmdArgs, ArgStringList LibraryPaths,
+ String
tra added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:29-47
+static bool addBCLib(Compilation &C, const ArgList &Args,
+ ArgStringList &CmdArgs, ArgStringList LibraryPaths,
+ StringRef BCName) {
+ StringRef FullName;
+ bool
yaxunl updated this revision to Diff 148216.
yaxunl marked 19 inline comments as done.
yaxunl retitled this revision from "[HIP] Let CUDA toolchain support HIP
language mode and amdgpu" to "Add HIP toolchain".
yaxunl edited the summary of this revision.
yaxunl added a comment.
Herald added a subsc
