tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
One small nit. LGTM otherwise. ================ Comment at: lib/Driver/ToolChains/HIP.cpp:44 + } + if (!FoundLibDevice) + C.getDriver().Diag(diag::err_drv_no_such_file) << BCName; ---------------- You don't need FoundLibDevice any more as you will always return from inside the loop if it is ever true. https://reviews.llvm.org/D45212 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
