[PATCH] D45045: [DebugInfo] Generate debug information for labels.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL352025: Reland r345009 "[DebugInfo] Generate debug information for labels." (authored by HsiangKai, committed by ). Chang

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. D54199 and D54465 have been accepted and landed. I have tested the revision with LLVM test and Clang test. They are all passed. Chromium build is also successful in my local environment. I think it is

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. In https://reviews.llvm.org/D45045#1299507, @tyb0807 wrote: > Hello all, > > This commit has been reverted by https://reviews.llvm.org/rC345026. It was > reported that this broke the Chromium build (again). Have you had a look to > fix this, @HsiangKai? I have fixed

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

tyb0807 reopened this revision. tyb0807 added a comment. Hello all, This commit has been reverted by https://reviews.llvm.org/rC345026. It was reported that this broke the Chromium build (again). Have you had a look to fix this, @HsiangKai? Repository: rC Clang https://reviews.llvm.org/D45

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC345009: [DebugInfo] Generate debug information for labels. (After fix PR39094) (authored by HsiangKai, committed by ). Ch

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

aprantl added a comment. In https://reviews.llvm.org/D45045#1270442, @HsiangKai wrote: > In https://reviews.llvm.org/D45045#1247427, @vitalybuka wrote: > > > Reverted in r343183 > > https://bugs.llvm.org/show_bug.cgi?id=39094 > > > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-aut

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. In https://reviews.llvm.org/D45045#1247427, @vitalybuka wrote: > Reverted in r343183 > https://bugs.llvm.org/show_bug.cgi?id=39094 > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/29356/steps/build%20release%20tsan%20with%20clang/logs/stdi

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. Fix the bug in https://reviews.llvm.org/D52927. Repository: rL LLVM https://reviews.llvm.org/D45045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

vitalybuka reopened this revision. vitalybuka added a comment. Reverted in r343183 https://bugs.llvm.org/show_bug.cgi?id=39094 http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/29356/steps/build%20release%20tsan%20with%20clang/logs/stdio Repository: rL LLVM https://revi

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

mstorsjo added a comment. The latest reland of this change still causes compilation crashes, see PR 39094. I'll revert this change for now to fix compilation again. Repository: rL LLVM https://reviews.llvm.org/D45045 ___ cfe-commits mailing list

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

sammccall added a comment. The latest reland of this patch triggers a segfault in clang (seemingly only on k8 and ppc). I've bisected it to r341519 but don't understand the cause. The stacktrace is: 1. parser at end of file 2.Code generation #0 0x5649754494d4 SignalHandler(int)

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. Hi @vext01, It should be fixed in https://reviews.llvm.org/D50495. Please help me to confirm it in your environment. Thanks so much. :) Repository: rL LLVM https://reviews.llvm.org/D45045 ___ cfe-commits mailing list c

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

vext01 added a comment. Got one! Here's a dumb program which simply adds 3 to 1 using a function. There is one label in the `add_3` function, named `XXXYYYZZZ`: ; ModuleID = 'mymod' source_filename = "mymod" define i32 @add_3(i32 %x) !dbg !3 { entry: %res = add i32 %x, 3, !dbg !9

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

vext01 added a comment. Hi, I'm generating these labels from the Rust compiler, which is far from a minimal example. I'm actually conflicted about what should happen if code containing a label is removed, but the label is marked to be "retained". Maybe it does make sense for those to stay wit

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. In https://reviews.llvm.org/D45045#1189201, @vext01 wrote: > Hi, > > I've been experimenting some more with this patch. > > It seems to me that if a label is optimised away, but you've requested it be > preserved, then you get a DWARF label with a zero offset. Is that

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

vext01 added a comment. Hi, I've been experimenting some more with this patch. It seems to me that if a label is optimised away, but you've requested it be preserved, then you get a DWARF label with a zero offset. Is that the expected behaviour? Should it be documented? E.g.: < 6><0x00

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

vext01 added a comment. Hi HsiangKai, Thanks for the response. Indeed, I've just rolled back to just before the revert for now to experiment, but I do hope this change hits LLVM-7. Wishing you the best of luck with getting it merged! Repository: rL LLVM https://reviews.llvm.org/D45045

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. In https://reviews.llvm.org/D45045#1184313, @vext01 wrote: > Looks like this was backed out (reverted) yesterday. > > I'm really interested in inserting DILabels from LLVM in my research project, > so I hope it can be recovered. You could apply it locally. In most ca

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

vext01 added a comment. Looks like this was backed out (reverted) yesterday. I'm really interested in inserting DILabels from LLVM in my research project, so I hope it can be recovered. Repository: rL LLVM https://reviews.llvm.org/D45045 ___ cf

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

hans added a comment. In https://reviews.llvm.org/D45045#1150525, @HsiangKai wrote: > In https://reviews.llvm.org/D45045#1114280, @HsiangKai wrote: > > > In https://reviews.llvm.org/D45045#1092697, @hans wrote: > > > > > This broke the Chromium build. I've uploaded a reproducer at > > > https://

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. In https://reviews.llvm.org/D45045#1114280, @HsiangKai wrote: > In https://reviews.llvm.org/D45045#1092697, @hans wrote: > > > This broke the Chromium build. I've uploaded a reproducer at > > https://bugs.chromium.org/p/chromium/issues/detail?id=841170#c1 > > > > I'm g

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. In https://reviews.llvm.org/D45045#1092697, @hans wrote: > This broke the Chromium build. I've uploaded a reproducer at > https://bugs.chromium.org/p/chromium/issues/detail?id=841170#c1 > > I'm guessing maybe a Clang bootstrap with debug info might also reproduce the

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

hans added a comment. This broke the Chromium build. I've uploaded a reproducer at https://bugs.chromium.org/p/chromium/issues/detail?id=841170#c1 I'm guessing maybe a Clang bootstrap with debug info might also reproduce the problem, but I haven't tried that. Reverted in r331861. Repository:

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL331843: [DebugInfo] Generate debug information for labels. (authored by shiva, committed by ). Changed prior to commit:

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai marked an inline comment as done. HsiangKai added a comment. @chenwj Do you have any comments for this patch? Repository: rC Clang https://reviews.llvm.org/D45045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai updated this revision to Diff 143243. HsiangKai added a comment. - Update test cases. - Checked with clang-format. Repository: rC Clang https://reviews.llvm.org/D45045 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGStmt.cpp test/CodeGen/backend-u

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

JDevlieghere added a comment. Please run your changes through clang format before checking this in; otherwise LGTM. Repository: rC Clang https://reviews.llvm.org/D45045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai marked 2 inline comments as done. HsiangKai added a comment. Always add labels to DISubprogram even unreachable. Repository: rC Clang https://reviews.llvm.org/D45045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai updated this revision to Diff 142533. HsiangKai added a comment. Update test cases. Repository: rC Clang https://reviews.llvm.org/D45045 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGStmt.cpp test/CodeGen/debug-label-inline.c test/CodeGen/debu

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

aprantl added a comment. One question, but otherwise this looks fine. Comment at: lib/CodeGen/CGStmt.cpp:535 + + // Emit debug info for the label only if it's reachable. + if (HaveInsertPoint()) { Shouldn't it be added to the list of labels/variables of the D

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai updated this revision to Diff 141989. HsiangKai added a comment. Update the test case for inlined functions. The inlined label will attach to DISubprogram(..., labels: !n) Repository: rC Clang https://reviews.llvm.org/D45045 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeb

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai updated this revision to Diff 140627. HsiangKai retitled this revision from "[DebugInfo] Generate DILabel metadata for labels." to "[DebugInfo] Generate debug information for labels.". HsiangKai edited the summary of this revision. Herald added a subscriber: eraman. Repository: rC Cla