hans added a comment. In https://reviews.llvm.org/D45045#1150525, @HsiangKai wrote:
> In https://reviews.llvm.org/D45045#1114280, @HsiangKai wrote: > > > In https://reviews.llvm.org/D45045#1092697, @hans wrote: > > > > > This broke the Chromium build. I've uploaded a reproducer at > > > https://bugs.chromium.org/p/chromium/issues/detail?id=841170#c1 > > > > > > I'm guessing maybe a Clang bootstrap with debug info might also reproduce > > > the problem, but I haven't tried that. > > > > > > Reverted in r331861. > > > > > > https://reviews.llvm.org/D46738 should fix the bug. > > > https://reviews.llvm.org/rL336176 has fixed the bug. Could I revert the > commit? > You could refer to PR37395. I'm not familiar with your patch, but if you're confident that it works (for example, a clang bootstrap works), then committing again sounds good to me. Repository: rL LLVM https://reviews.llvm.org/D45045 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
