espindola closed this revision.
espindola added a comment.
328801
https://reviews.llvm.org/D44723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I'd add more tests but I can't think of ways to remove the dll attributes, only
to flip them.
Do we already have dso_local tests for this similar case:
__declspec(dllimport) void f();
voi
espindola added a comment.
ping
https://reviews.llvm.org/D44723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
espindola created this revision.
espindola added reviewers: rnk, echristo.
https://reviews.llvm.org/D44723
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/dllimport.cpp
Index: test/CodeGenCXX/dllimport.cpp
===
--- test/Cod
