rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

I'd add more tests but I can't think of ways to remove the dll attributes, only 
to flip them.

Do we already have dso_local tests for this similar case:

  __declspec(dllimport) void f();
  void g() { f(); } // use it
  void f() { }

It flips from dllimport to dllexport.


https://reviews.llvm.org/D44723



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D44723: ... Rafael Avila de Espindola via Phabricator via cfe-commits
    • [PATCH] D44... Rafael Avila de Espindola via Phabricator via cfe-commits
    • [PATCH] D44... Reid Kleckner via Phabricator via cfe-commits
    • [PATCH] D44... Rafael Avila de Espindola via Phabricator via cfe-commits

Reply via email to