jkorous-apple added inline comments.
Comment at: clang-tools-extra/trunk/clangd/ClangdServer.h:131
+ // Features like indexing must be enabled if desired.
+ static Options optsForTest();
+
Shouldn't this be better implemented as a utility function in tests?
Al
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326719: [clangd] Extract ClangdServer::Options struct.
(authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44088
Files:
cla
sammccall updated this revision to Diff 136991.
sammccall marked 3 inline comments as done.
sammccall added a comment.
address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44088
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServ
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:94
+ /// Returns a statically allocated instance. (Stateless, safe to share).
+ static RealFileSystemProvider *get();
+
Maybe return a reference instead of a pointer?
Comm
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek.
This subsumes most of the params to ClangdServer and ClangdLSPServer.
Adjacent changes:
- tests use a consistent set of options, except when testing sp
