jkorous-apple added inline comments.
================ Comment at: clang-tools-extra/trunk/clangd/ClangdServer.h:131 + // Features like indexing must be enabled if desired. + static Options optsForTest(); + ---------------- Shouldn't this be better implemented as a utility function in tests? Also what is the purpose of making global function in header file static? Repository: rL LLVM https://reviews.llvm.org/D44088 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits