This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325491: [clangd] Attach more information about Sema
completion to traces (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43377?vs=134889&id=134892#toc
Repos
ilya-biryukov updated this revision to Diff 134889.
ilya-biryukov added a comment.
- Rename usage of printCompletionKind to getCompletionKindString
- Remove tracing of the filename, TUScheduler now provides those traces
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43377
Files
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:503
+trace::Span Span("Process sema results");
+SPAN_ATTACH(Span, "total_sema_items", NumResults);
sammccall wrote:
> I think this s
ilya-biryukov updated this revision to Diff 134589.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Attach completion kind in CodeCompleteFlow::run().
- Move printCompletionKind closer to CompletionContext::Kind.
- Added FIXME to remove tracing of filename.
Repos
sammccall added a comment.
This looks really useful! Main suggestion is to drop the added span and attach
kind to the main span instead. (It's relevant to index too, not just to sema)
Comment at: clangd/CodeComplete.cpp:403
+StringRef printCompletionKind(enum CodeCompletionC
ilya-biryukov added a comment.
Technically this is NFC, but it has a huge `toString` helper and I'm not sure
if I chose the appropriate place for logging the filename.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43377
___
cfe-co
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, sammccall.
Herald added subscribers: jkorous-apple, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43377
Files:
clangd/CodeComplete.cpp
Index: clangd/CodeComplete.cpp
==
