This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325491: [clangd] Attach more information about Sema completion to traces (authored by ibiryukov, committed by ).
Changed prior to commit: https://reviews.llvm.org/D43377?vs=134889&id=134892#toc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43377 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp =================================================================== --- clangd/CodeComplete.cpp +++ clangd/CodeComplete.cpp @@ -855,9 +855,12 @@ CompletionList Output; semaCodeComplete(std::move(RecorderOwner), Opts.getClangCompleteOpts(), SemaCCInput, [&] { - if (Recorder.CCSema) + if (Recorder.CCSema) { Output = runWithSema(); - else + SPAN_ATTACH( + Tracer, "sema_completion_kind", + getCompletionKindString(Recorder.CCContext.getKind())); + } else log("Code complete: no Sema callback, 0 results"); });
Index: clangd/CodeComplete.cpp =================================================================== --- clangd/CodeComplete.cpp +++ clangd/CodeComplete.cpp @@ -855,9 +855,12 @@ CompletionList Output; semaCodeComplete(std::move(RecorderOwner), Opts.getClangCompleteOpts(), SemaCCInput, [&] { - if (Recorder.CCSema) + if (Recorder.CCSema) { Output = runWithSema(); - else + SPAN_ATTACH( + Tracer, "sema_completion_kind", + getCompletionKindString(Recorder.CCContext.getKind())); + } else log("Code complete: no Sema callback, 0 results"); });
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits