[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325242: [clangd] Enable snippet completion based on client capabilities. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D4

[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

ilya-biryukov added a comment. As discussed offline with @sammccall, we don't really need to hold `Optional<>` fields for configuration entries, as we only consume them in clangd and therefore can just set the default values explicitly. Makes the code simpler and requires only one extra test (wi

[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

ilya-biryukov updated this revision to Diff 134421. ilya-biryukov added a comment. - Removed completion-snippets-missing.test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43229 Files: clangd/ClangdLSPServer.cpp clangd/Protocol.cpp clangd/Protocol.h clangd/tool/ClangdM

[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

ilya-biryukov updated this revision to Diff 134420. ilya-biryukov added a comment. - Use default values for configuration instead of using Optional<> fields. - Removed redundant tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43229 Files: clangd/ClangdLSPServer.cpp cl

[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

ilya-biryukov added inline comments. Comment at: test/clangd/completion-snippets-disabled.test:1 +# RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s +# RUN: clangd -lit-test -pch-storage=memory < %s | FileCheck -strict-whitespace %s sammccall wrote:

[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

sammccall added inline comments. Comment at: clangd/tool/ClangdMain.cpp:60 -static llvm::cl::opt EnableSnippets( -"enable-snippets", ilya-biryukov wrote: > ioeric wrote: > > Would we still have a way to disable snippets (e.g. for debugging) even if > > cli

[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:90 void ClangdLSPServer::onInitialize(InitializeParams &Params) { + if (Params.rootUri && !Params.rootUri->file.empty()) +Server.setRootPath(Params.rootUri->file); ioeric wrote: > T

[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

ilya-biryukov updated this revision to Diff 134405. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Remove initializers from Optional<> fields Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43229 Files: clangd/ClangdLSPServer.cpp clangd/Prot

[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clangd/ClangdLSPServer.cpp:90 void ClangdLSPServer::onInitialize(InitializeParams &Params) { + if (Params.rootUri && !Params.rootUri->file.empty()) +Se

[PATCH] D43229: [clangd] Enable snippet completion based on client capabilities.

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, sammccall. Herald added subscribers: jkorous-apple, klimek. And remove -enable-snippets flag. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43229 Files: clangd/ClangdLSPServer.cpp clangd/Pr