ilya-biryukov added a comment. As discussed offline with @sammccall, we don't really need to hold `Optional<>` fields for configuration entries, as we only consume them in clangd and therefore can just set the default values explicitly. Makes the code simpler and requires only one extra test (with snippets enabled).
Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43229 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
