This revision was automatically updated to reflect the committed changes.
Closed by commit rL324888: [clangd] Log all ignored diagnostics. (authored by
ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43123
Files:
clang-tools-
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clangd/ClangdUnit.cpp:197
-
-log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}",
- Location, Message));
---
ilya-biryukov updated this revision to Diff 133827.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Renamed logIgnoredDiag to log.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43123
Files:
clangd/ClangdUnit.cpp
clangd/Compiler.cpp
clangd
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:197
-
-log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}",
- Location, Message));
hokein wrote:
> I'm not sure, do we care about this particular case (
hokein added inline comments.
Comment at: clangd/ClangdUnit.cpp:197
-
-log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}",
- Location, Message));
I'm not sure, do we care about this particular case (diagnostic outside main
ilya-biryukov created this revision.
ilya-biryukov added reviewers: ioeric, hokein, sammccall.
Herald added subscribers: jkorous-apple, klimek.
To aid debugging failures and crashes.
Only part of ignored diagnostics was logged before, now we log all of
them.
Repository:
rCTE Clang Tools Extra
