This revision was automatically updated to reflect the committed changes.
Closed by commit rL324675: Add NVPTX Support to ValidCPUList (enabling march
notes) (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4304
tra added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
erichkeane wrote:
> tra wr
erichkeane added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
tra wrote:
> Nit: G
Fair. Did you want to handle this a different way? I thought the list at
least seemed reasonable for spelling.
On Thu, Feb 8, 2018, 11:44 AM Artem Belevich via Phabricator <
revi...@reviews.llvm.org> wrote:
> tra added inline comments.
>
>
>
> Comment at: test/Misc/target-invalid
tra added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
Nit: Generally speaking th
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM with an inline comment.
Comment at: include/clang/Basic/Cuda.h:49
SM_72,
+ LAST,
};
We have last, invalid, etc... maybe we should pick one amon
erichkeane updated this revision to Diff 133458.
erichkeane added a comment.
rebased, reflowed tests.
https://reviews.llvm.org/D43045
Files:
include/clang/Basic/Cuda.h
lib/Basic/Cuda.cpp
lib/Basic/Targets/NVPTX.cpp
lib/Basic/Targets/NVPTX.h
test/Misc/target-invalid-cpu-note.c
Index:
erichkeane created this revision.
erichkeane added reviewers: samparker, fhahn, rengolin, echristo, Hahnfeld.
Herald added a subscriber: jholewinski.
A followup to: https://reviews.llvm.org/D42978
This patch adds NVPTX support for
enabling the march notes.
Repository:
rC Clang
https://reviews
