[PATCH] D41374: [Coverage] Fix use-after free in coverage emission

2017-12-18 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321052: [Coverage] Fix use-after free in coverage emission (authored by efriedma, committed by ). Changed prior to commit: https://reviews.llvm.org/D41374?vs=127440&id=127451#toc Repository: rL LLVM

[PATCH] D41374: [Coverage] Fix use-after free in coverage emission

2017-12-18 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, this lgtm as a stopgap. As I mentioned offline, I think the goal should be to have non-modules and modules-enabled builds of a project produce identical coverage reports. I'll look into wha

[PATCH] D41374: [Coverage] Fix use-after free in coverage emission

2017-12-18 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added reviewers: vsk, davidxl. efriedma added a project: clang. Fixes regression from r320533. This fixes the undefined behavior, but I'm not sure it's really right... I think we end up with missing coverage for code in modules. Repository: rC Clang