This revision was automatically updated to reflect the committed changes.
Closed by commit rL330627: [libcxx] implement
declarations based on P0214R7. (authored by timshen, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
timshen updated this revision to Diff 143610.
timshen added a comment.
Update formatting on static_asserts.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/include/module.modulemap
libcxx/test/libcxx/double_include.sh.c
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: bixia.
This looks ready to land to me.
Comment at:
libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp:122
+static_asser
timshen updated this revision to Diff 141436.
timshen marked an inline comment as done.
timshen added a comment.
Update file comments copy-paste error.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/include/module.module
timshen marked 5 inline comments as done.
timshen added inline comments.
Comment at:
libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp:68
+
+static_assert(!is_simd_mask::value, "");
+
mclow.lists wrote:
> How about a couple more negative tests
timshen updated this revision to Diff 141188.
timshen added a comment.
Addressed comments.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/include/module.modulemap
libcxx/test/libcxx/double_include.sh.cpp
libcxx/test/
mclow.lists added inline comments.
Comment at: libcxx/test/std/experimental/simd/simd.traits/is_abi_tag.pass.cpp:44
+static_assert(is_abi_tag>::value, "");
+static_assert(is_abi_tag>::value, "");
+
Needs negative tests.
Comment at: libcxx/test
mclow.lists added a comment.
When you add a new header file to libc++, you have to update two additional
files:
- include/module.modulemap
- test/libcxx/double_include.sh.cpp
See http://llvm.org/viewvc/llvm-project?view=revision&revision=329144 for an
example of how to do this.
timshen updated this revision to Diff 139393.
timshen marked 7 inline comments as done.
timshen added a comment.
Address comments.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/nothing_to_do.p
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:669
+
+#if _LIBCPP_STD_VER > 14 && !defined(_LIBCPP_HAS_NO_VARIABLE_TEMPLATES)
+template
mclow.lists wrote:
> Isn't the parallelism TS based on C++17?
>
I intended to have a C++11 (and
mclow.lists added a comment.
I'm going to stop here, because all the things I've noted are ticky-tack;
formatting and minor changes.
More substantial comments coming soon.
Comment at: libcxx/include/experimental/simd:40
+template inline constexpr bool is_abi_tag_v = is_abi_ta
timshen updated this revision to Diff 139036.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp
libcx
timshen updated this revision to Diff 129007.
timshen added a comment.
Rebased.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp
libcxx/test/std/experimental/simd/simd.ca
timshen updated this revision to Diff 128679.
timshen added a comment.
Rebase.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp
libcxx/test/std/experimental/simd/simd.cas
timshen updated this revision to Diff 127622.
timshen added a comment.
include "test_macros.h" in the tests
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp
libcxx/test/s
timshen updated this revision to Diff 127399.
timshen added a comment.
Formatted the files.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp
libcxx/test/std/experimental/
timshen updated this revision to Diff 126872.
timshen marked 7 inline comments as done.
timshen added a comment.
Address second round of comments.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:594
+
+#warning " is under construction and not for practical use
for now."
+
EricWF wrote:
> I would just remove this. The `experimental` part of the name should say
> enough.
>
> Als
EricWF added inline comments.
Comment at: libcxx/include/experimental/simd:1
+#ifndef _LIBCPP_EXPERIMENTAL_SIMD
+#define _LIBCPP_EXPERIMENTAL_SIMD
Please add the license header similar to `experimental/filesystem`.
Comment at: libcxx/include/ex
timshen marked 4 inline comments as done.
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:1069
+std::is_same<_Abi, simd_abi::fixed_size>::value &&
+__is_non_narrowing_convertible<_Up, _Tp>()>::type>
+ simd(const simd<_U
timshen updated this revision to Diff 126813.
timshen added a comment.
Address comments:
- Generator ctor is implementable
- Format issues of tests
- SFINAE on __is_non_narrowing_convertible for arithmetics only.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/simd
libcx
lichray added a comment.
I beg you to resubmit this patch relative to "libcxx"; I had to `arc export`
this patch and `patch -p1 < your.diff` manually rather than just `arc patch
D41148`.
Comment at: libcxx/include/experimental/simd:1069
+std::is_same<_Abi, sim
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
The patch includes all declarations, and also implements the following features:
- ABI.
- narrowing-conversion related SFIANE, including simd<> ctors and
(sta
23 matches
Mail list logo
