This revision was automatically updated to reflect the committed changes.
Closed by commit rL319647: [clangd] GlobalCompilationDatabase interface changes
(authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D40733?vs=125151&id=125303#toc
Repository:
rL LLVM
https://rev
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clangd/ClangdUnitStore.cpp:67
// FIXME: Don't overwrite it if it's already there.
- Commands.front().CommandLine.push_back("-resource-dir=" +
-
sammccall created this revision.
Herald added subscribers: cfe-commits, klimek.
- GlobalCompilationDatabase now returns a single command (that's all we use)
- fallback flags are now part of the GlobalCompilationDatabase. There's a
default implementation that they can optionally customize.
- this
