hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clangd/ClangdUnitStore.cpp:67
// FIXME: Don't overwrite it if it's already there.
- Commands.front().CommandLine.push_back("-resource-dir=" +
- std::string(ResourceDir));
- return std::move(Commands.front());
+ C->CommandLine.push_back("-resource-dir=" + std::string(ResourceDir));
+ return std::move(*C);
----------------
nit: you can use `ResourceDir.str()`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40733
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
