This revision was automatically updated to reflect the committed changes.
Closed by commit rL315989: [CodeGen] Refine generation of TBAA info for
bit-field lvalues (authored by kosarev).
Changed prior to commit:
https://reviews.llvm.org/D38947?vs=119257&id=119288#toc
Repository:
rL LLVM
htt
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, thanks.
https://reviews.llvm.org/D38947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
kosarev added a comment.
Yes, some preparation code moved past the isBitField() block and generation of
TBAA info moved before creating the bit-field lvalue.
Thanks for catching the BaseExpr renaming.
https://reviews.llvm.org/D38947
___
cfe-commit
kosarev updated this revision to Diff 119257.
kosarev added a comment.
- Removed renamings that complicate reviewing.
https://reviews.llvm.org/D38947
Files:
lib/CodeGen/CGExpr.cpp
Index: lib/CodeGen/CGExpr.cpp
===
--- lib/CodeGe
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:3665
-LValue CodeGenFunction::EmitLValueForField(LValue base,
- const FieldDecl *field) {
- LValueBaseInfo BaseInfo = base.getBaseInfo();
- AlignmentSource fieldAlignS
kosarev created this revision.
kosarev added a project: clang.
The main change is that now we generate TBAA info before constructing the
resulting lvalue instead of constructing lvalue with some default TBAA info and
fixing it as necessary afterwards. We also keep the TBAA info close to lvalue
