[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316565: [clangd] Added a callback-based codeComplete in clangd. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D38629?vs=119813&id=120218#toc Repository: rL LLVM https://

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:51 +template +std::future makeFutureAPIFromCallback( sammccall wrote: > I'm not sure we need a template here rather than just writing the code > directly. Removed the template, inlined i

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 119813. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Inlined makeFutureAPIFromCallback. https://reviews.llvm.org/D38629 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h Index: clangd/ClangdServer.h

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clangd/ClangdServer.cpp:51 +template +std::future makeFutureAPIFromCallback( I'm not sure we need a template here rather than just writing the code directly. Comment at: clangd/ClangdServer.cpp:25

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-09 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. We had a discussion with @sammccall offline, probably > - what's the goal? Make the code read more naturally, change the async model, > or something else? Callback API is more flexible (if `std::future` that we use had `then`, they'd be equivalent). We have inte

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-09 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 118225. ilya-biryukov added a comment. - Added a deprecation notice to function description. https://reviews.llvm.org/D38629 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h Index: clangd/ClangdServer.h ===

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. I'm missing some context for this one: - what's the goal? Make the code read more naturally, change the async model, or something else? - what's the end state for codeComplete specifically? will we switch to the new overload and delete the other, or is makeFutureAPIFr

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-06 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. I hope the whole design doesn't seem overly complicated. Very much open to suggestions on how to simplify it :-) https://reviews.llvm.org/D38629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-06 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. https://reviews.llvm.org/D38629 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h Index: clangd/ClangdServer.h === --- clangd/ClangdServer.h +++ clangd/ClangdServer.h @@ -252,6 +252,14 @@