ilya-biryukov added a comment. We had a discussion with @sammccall offline, probably
> - what's the goal? Make the code read more naturally, change the async model, > or something else? Callback API is more flexible (if `std::future` that we use had `then`, they'd be equivalent). We have internal clients that want to be notified about results of code completion without > - what's the end state for codeComplete specifically? will we switch to the > new overload and delete the other, or is `makeFutureAPIFromCallback` here to > stay? I think the way to go would be exactly that, switch to the new API and remove the older one. There are usages in tests, `ClangdLSPServer` and in our internal client, but I'll remove them with a separate commit later. Added a deprecation notice for the API. https://reviews.llvm.org/D38629 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
